Improved code readability #6
Merged
warengonzaga merged 2 commits intoOSSPhilippines:devfrom Mar 27, 2020
ianvizarra:dev
Merged
Conversation
Member
warengonzaga
left a comment
warengonzaga
left a comment
There was a problem hiding this comment.
I'm using ESLint.. via VSCode... will it work?
warengonzaga
approved these changes
Mar 27, 2020
Member
warengonzaga
left a comment
warengonzaga
left a comment
There was a problem hiding this comment.
Thank you for revising this...
Member
|
Thank you for your contribution @ianvizarra |
Contributor
Author
|
You're welcome @warengonzaga. Are you using gitflow? When is the next release? |
Member
|
Yes I'm using a gitflow @ianvizarra I'm working locally... I can't say when the v3 to release I have to fix the issue in ISO 3166... the API doesn't server in that way so I have to implement a filtering for ISO 3166 and return the correct value. If you can figure it out please let me know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I removed the optional curly brackets. It's not required if only one expression is present.
The function
isCommandlinecan also be refactored to:P.S
Kudos Sir!